Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vararg ABI on PowerPC #95

Merged
merged 2 commits into from
Dec 1, 2020
Merged

Conversation

vchuravy
Copy link
Contributor

@vchuravy vchuravy commented Dec 1, 2020

Should fix JuliaLang/julia#38628

On most platforms this doesn't make a difference, but on PPC
the callee can overrride the callers stack, see JuliaLang/julia#30821

@vchuravy
Copy link
Contributor Author

vchuravy commented Dec 1, 2020

Does indeed seem to fix the issue on PowerPC.

@vchuravy
Copy link
Contributor Author

vchuravy commented Dec 1, 2020

@Keno maybe you can take a look to double-check that I am using the Vararg correctly?

src/lC_curl_h.jl Outdated Show resolved Hide resolved
@vchuravy
Copy link
Contributor Author

vchuravy commented Dec 1, 2020

@StefanKarpinski if this looks ok to you, could you merge this?

@StefanKarpinski
Copy link
Contributor

Did you edit these files manually?

@vchuravy
Copy link
Contributor Author

vchuravy commented Dec 1, 2020

Did you edit these files manually?

Yes I did.

@StefanKarpinski
Copy link
Contributor

Ok, that's not ideal since these files are generated, but I don't actually know how to generate these files in the condition they were generated in and when I've tried to regenerate them I get very different results that don't work, so I think we have to essentially view this code base as no longer being something we can generate. Ideally, someone would figure out how to use Clang.jl to generate working bindings from a more recent version of Clang and libcurl in a way that satisfies the ABI on all platforms, but for now it seems fine to merge this.

@StefanKarpinski StefanKarpinski merged commit 8310487 into JuliaWeb:master Dec 1, 2020
@vchuravy vchuravy deleted the vc/varargs branch December 1, 2020 23:48
@tanmaykm tanmaykm mentioned this pull request Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segmentation fault during Downloads.Curl.Easy() creation
4 participants