-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vararg ABI on PowerPC #95
Conversation
Does indeed seem to fix the issue on PowerPC. |
@Keno maybe you can take a look to double-check that I am using the Vararg correctly? |
@StefanKarpinski if this looks ok to you, could you merge this? |
Did you edit these files manually? |
Yes I did. |
Ok, that's not ideal since these files are generated, but I don't actually know how to generate these files in the condition they were generated in and when I've tried to regenerate them I get very different results that don't work, so I think we have to essentially view this code base as no longer being something we can generate. Ideally, someone would figure out how to use Clang.jl to generate working bindings from a more recent version of Clang and libcurl in a way that satisfies the ABI on all platforms, but for now it seems fine to merge this. |
Should fix JuliaLang/julia#38628
On most platforms this doesn't make a difference, but on PPC
the callee can overrride the callers stack, see JuliaLang/julia#30821